Skip to content

chore: update ci/cd env vars, tests, examples for v2 keys#453

Merged
anitarua merged 9 commits intomainfrom
update-tests-examples
Dec 20, 2025
Merged

chore: update ci/cd env vars, tests, examples for v2 keys#453
anitarua merged 9 commits intomainfrom
update-tests-examples

Conversation

@anitarua
Copy link
Contributor

@anitarua anitarua commented Dec 19, 2025

  1. refactored auth utils so there's only one method extracting env vars
  2. updated examples to use v2 api key
  3. updated tests to use v1 api key + added v2 api key tests
  4. updated github actions workflows to provide the new env vars

@anitarua anitarua requested a review from nand4011 December 20, 2025 00:24
Co-authored-by: Nate Anderson <nate@momentohq.com>
@anitarua anitarua requested a review from nand4011 December 20, 2025 00:43
Copy link
Contributor

@nand4011 nand4011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CONTRIBUTING.md mentions that both V1 and V2 api keys need to be set for the tests to work.

@anitarua anitarua requested a review from nand4011 December 20, 2025 01:09
@anitarua anitarua merged commit 0c7fd20 into main Dec 20, 2025
4 of 6 checks passed
@anitarua anitarua deleted the update-tests-examples branch December 20, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants