Skip to content

fix: remove client-side expiry check on disposable tokens #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anitarua merged 1 commit into from
Feb 4, 2026
Merged

fix: remove client-side expiry check on disposable tokens #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions momento-sdk/src/main/java/momento/sdk/ValidationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ public final class ValidationUtils {

static final String DISPOSABLE_TOKEN_EXPIRY_MUST_BE_POSITIVE =
"Disposable token expiry must be positive";
static final String DISPOSABLE_TOKEN_EXPIRY_EXCEEDS_ONE_HOUR =
"Disposable token must expire within 1 hour";
static final String DISPOSABLE_TOKEN_MUST_HAVE_AN_EXPIRY =
"Disposable tokens must have an expiry";
static final String LEADERBOARD_NAME_IS_REQUIRED = "Non-empty leaderboard name is required.";
Expand Down Expand Up @@ -141,8 +139,6 @@ static void ensureValidTruncateToSize(Integer truncateToSize) {
static void checkValidDisposableTokenExpiry(ExpiresIn expiresIn) {
if (!expiresIn.doesExpire()) {
throw new InvalidArgumentException(DISPOSABLE_TOKEN_MUST_HAVE_AN_EXPIRY);
} else if (expiresIn.getSeconds() > 60 * 60) {
throw new InvalidArgumentException(DISPOSABLE_TOKEN_EXPIRY_EXCEEDS_ONE_HOUR);
} else if (expiresIn.getSeconds() <= 0) {
throw new InvalidArgumentException(DISPOSABLE_TOKEN_EXPIRY_MUST_BE_POSITIVE);
}
Expand Down
Loading