feat: new credential provider methods for accepting global api keys#512
Merged
feat: new credential provider methods for accepting global api keys#512
Conversation
malandis
reviewed
Dec 16, 2025
malandis
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1264
Deprecates
from_environment_variableandfrom_stringwhich accept v1 and legacy auth tokens. Leaving the functionality though.Adds
from_api_key_v2,from_environment_variables_v2, andfrom_disposable_tokento support the non-legacy api keys.Uses helper function
_is_v2_api_keyto determine if a received key is a jwt with the expected v2 claims.