chore: update workflows, examples, tests, readmes for api keys v2#514
Merged
chore: update workflows, examples, tests, readmes for api keys v2#514
Conversation
nand4011
approved these changes
Jan 7, 2026
| def example_API_CredentialProviderFromEnvVar(): | ||
| CredentialProvider.from_environment_variable("MOMENTO_API_KEY") | ||
| CredentialProvider.from_environment_variable("V1_API_KEY") | ||
|
|
Contributor
There was a problem hiding this comment.
This might be better to fix in the dev docs parsing logic, but I'm pretty sure the two blank lines between the code and #end example end up included in the code snippet in docs.
Contributor
Author
There was a problem hiding this comment.
have a ticket to make updates to the dev docs site for api keys v2, will make a note about this there
| _logger.info("hello") | ||
| with TopicClient(TopicConfigurations.Default.v1(), _AUTH_PROVIDER) as client: | ||
| with TopicClient( | ||
| TopicConfigurations.Default.v1().with_client_timeout(timedelta(seconds=10)), _AUTH_PROVIDER |
Contributor
There was a problem hiding this comment.
Since we need to override the client timeout, I think we should add a Laptop TopicConfiguration so we don't need to clutter the examples. That can be a follow up thing though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards https://github.com/momentohq/dev-eco-issue-tracker/issues/1276