Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
nodebalancer. The most important changes include updating the JSON structure in the README, modifying thebalances.goandconfigs.gofiles to include additional chain information, and updating thecontracts.jsonstructure.Documentation Updates:
nodebalancer/README.md: Updated the JSON structure to include additional chain information such aschain_id,name, andimage_url. The top-level keys are now chain IDs, and thebalancesare nested within each chain object. [1] [2]Codebase Enhancements:
nodebalancer/cmd/nodebalancer/balances.go: Introduced a newChainInfostruct to encapsulate chain-related information and updated theBalancesResponsetype to useChainInfoinstead ofChainBalances.nodebalancer/cmd/nodebalancer/balances.go: Modified thegetBalancesfunction to populate theBalancesResponsewithChainInfoobjects, includingchain_id,name, andimage_url.nodebalancer/cmd/nodebalancer/configs.go: Added new fields to theChainConfigstruct forchain_id,name, andimage_url.These changes improve the readability and usability of the JSON responses and configuration files by including more detailed information about each blockchain.
response example.
{ "1": { "chain_id": "1", "name": "ethereum", "image_url": "https://example.com/eth.png", "balances": { "0x0000000000000000000000000000000000000000": "1000000000000000000", "0xdac17f958d2ee523a2206206994597c13d831ec7": "2000000000000000000", "0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48": "3000000000000000" } }, "137": { "chain_id": "137", "name": "polygon", "image_url": "https://example.com/matic.png", "balances": { "0x0000000000000000000000000000000000000000": "4000000000000000000", "0x2791bca1f2de4661ed88a30c99a7a9449aa84174": "5000000000000000", "0xc2132d05d31c914a87c6611c10748aeb04b58e8f": "6000000000000000000" } } }