Skip to content

fix(blockForDiffEquality):does not handle when diff is empty but file is different #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knowbased merged 2 commits into from
Nov 13, 2025
Merged

fix(blockForDiffEquality):does not handle when diff is empty but file is different #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4943199
fix: block doesnt handle when diff is same but file not
knowbased Oct 27, 2025
52bd33f
Refactor: replace parentheses with brackets
knowbased Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/GitProjectHealth-Model-Importer/GitModelImporter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,15 @@ GitModelImporter >> blockForBranchEquality [

{ #category : #equality }
GitModelImporter >> blockForDiffEquality [
^ [ :existing :new |
existing diffString size = new diffString size and: [
existing diffString = new diffString ] ]

^ [ :existing :new |
| sameSize sameDiff sameFile |
sameSize := existing diffString size = new diffString size.
sameDiff := existing diffString = new diffString.
sameFile := existing new_path = new new_path.

sameSize and: [ sameDiff and: [ sameFile ] ].
]
]

{ #category : #equality }
Expand Down