feat: remove irrelevant withConfig and withModel methods#8
Merged
moreirawebmaster merged 2 commits intomainfrom Jul 26, 2025
Merged
feat: remove irrelevant withConfig and withModel methods#8moreirawebmaster merged 2 commits intomainfrom
moreirawebmaster merged 2 commits intomainfrom
Conversation
…ttpTracking BREAKING CHANGE: Removed EngineHttpTracking.withConfig() and EngineHttpTracking.withModel() methods as they were deemed irrelevant for the new architecture. Use updateModel() for runtime configuration changes instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
withConfig()andwithModel()methods fromEngineHttpTrackingas they were deemed irrelevant for the new architecture.Changes Made
EngineHttpTracking.withConfig()methodEngineHttpTracking.withModel()methodupdateModel()insteadMigration
For runtime configuration changes, use
updateModel()instead:```dart
// Instead of withConfig() or withModel()
EngineHttpTracking.updateModel(newModel);
// Perform operations...
// Restore original model if needed
EngineHttpTracking.updateModel(originalModel);
```
Testing
Type of Change
Checklist