fix(frontend_acl): write ACLs to ha_acls section for config generation #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfSense's HAProxy config generator reads ACLs from the <ha_acls> XML section, not <a_acl>. The module was only writing to <a_acl>, causing ACLs created via Ansible to be missing from the generated haproxy.cfg. This fix adds parallel handling for the <ha_acls> section: - Initialize ha_acls_elt in _validate_params() - Add _find_ha_acl_target() to locate ACLs in ha_acls - Override _add() to create ACLs in both sections - Override _copy_and_update_target() to sync updates - Override _remove() to delete from both sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pfSense's HAProxy config generator reads ACLs from the <ha_acls> XML section, not <a_acl>. The module was only writing to <a_acl>, causing ACLs created via Ansible to be missing from the generated haproxy.cfg.
This fix adds parallel handling for the <ha_acls> section: