Fix bug for invalid sequencer BLS key

[Kukoomomo]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error handling in sequencer update processing. The system now continues processing valid updates when encountering invalid entries, rather than halting the entire operation when malformed data is detected.

[coderabbitai]

Walkthrough

In node/core/sequencers.go, the error handling in the sequencerSetUpdates function was modified. When BLS key decoding fails, the function now skips the invalid entry and continues processing remaining items instead of returning the error and halting.

Changes

Cohort / File(s)	Change Summary
Error handling modification node/core/sequencers.go	Modified sequencerSetUpdates to skip invalid BLS key decode errors instead of aborting; function now continues to next item on decode failure

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Risk consideration: Verify that skipping invalid entries doesn't introduce data inconsistencies or mask underlying issues with BLS key decoding
• Downstream impact: Confirm that downstream processing can safely handle partial/filtered stake data and won't produce unexpected state
• Edge cases: Review whether there are scenarios where failing fast (original behavior) was preferable for catching configuration or data quality issues early

Poem

🐰 A key that won't decode?
No need to halt the load!
We skip the broken stone,
And hop along alone,
With stakes that still proceed down the road! 🌿

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: fixing a bug related to invalid sequencer BLS key handling. It directly relates to the core modification in the pull request where the function now skips invalid BLS key entries instead of aborting.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/node_sequencer_update

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

node/core/sequencers.go (1)

98-103: Existing safeguard partially mitigates the risk; review comment's suggestions address additional concerns.

The code does have a safeguard at lines 41-43 in verifySignature() that checks if len(e.valsByTmKey) == 0 and returns an error. This will catch the catastrophic case of an empty validator set after the update at line 115 assigns potentially empty valsByTmKey to global state.

However, this safeguard is:

• Reactive, not proactive (catches at verification time, not at update time)
• Partial (only catches empty sets, not reduced/insufficient validator sets)
• Limited in observability (error detection without metrics or alerting for skipped keys)

The review comment's suggested improvements—validating the resulting set before state assignment (lines 115-116), logging invalid counts, and optionally enforcing minimum thresholds—address these gaps and would improve operational safety and observability. These are valid recommendations beyond what the existing safeguard provides.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28a6c0c and 03ef319.

📒 Files selected for processing (1)

• node/core/sequencers.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: check
• GitHub Check: test
• GitHub Check: check
• GitHub Check: test
• GitHub Check: check
• GitHub Check: test
• GitHub Check: test
• GitHub Check: Analyze (rust)
• GitHub Check: Analyze (go)