Add algorithm_names.hpp constants (fixes #238)#287
Open
SESHASHAYANAN wants to merge 1 commit intomotiwari:mainfrom
Open
Add algorithm_names.hpp constants (fixes #238)#287SESHASHAYANAN wants to merge 1 commit intomotiwari:mainfrom
SESHASHAYANAN wants to merge 1 commit intomotiwari:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fixes #238. This Pull Request standardizes the usage of algorithm names across the codebase by introducing a central header file: headers/algorithm_names.hpp.
This file defines constants for algorithm identifiers like BANDITPAM, PAM, and FASTPAM1. I have updated the core C++ implementation to use these constants instead of hardcoded string literals. This change improves code maintainability, prevents potential typo-related bugs, and ensures a single source of truth for algorithm naming conventions across the library.