config: add config-production-thunderbird.toml (bug 2012575)#83
Conversation
|
@coreycb if you want to have a look at the suggested mappings |
coreycb
left a comment
coreycb
left a comment
There was a problem hiding this comment.
Thanks! Generally looks good to me. I left a couple of comments, but they are probably just areas that I need clarity on and not actual issues.
shtrom
force-pushed
the
bug2012575/thunderbird-worker
branch
from
e35c411 to
f9c3cfd
Compare
| # destination_url = "ssh://hg.mozilla.org/releases/comm-release/" | ||
| # ESR | ||
| # tag_pattern = "^(THUNDERBIRD)_(\\d+)(_\\d+)+esr_(BUILD\\d+|RELEASE)$" | ||
| # destination_url = "ssh://hg.mozilla.org/releases/comm-esr\\2/" |
There was a problem hiding this comment.
Should there be a tag_pattern for comm-central?
Do the tag_patterns only include tags from the corresponding git branch?
I think the following would cover tags, assuming only tags from the corresponding git branches are included:
https://hg-edge.mozilla.org/comm-central/tags
(NIGHTLY)_(\d+)_(BASE|END)
(BETA)_(\d+)_(BASE|END)
https://hg-edge.mozilla.org/releases/comm-beta/tags
(NIGHTLY)_(\d+)_(BASE|END)
(BETA)_(\d+)_(BASE|END)
(RELEASE)_(\d+)_(BASE|END)
^(THUNDERBIRD)_(\\d+)_0b(\\d+)_(BUILD\\d+|RELEASE)$ # beta tags
https://hg-edge.mozilla.org/releases/comm-release/tags
(NIGHTLY)_(\d+)_(BASE|END)
(BETA)_(\d+)_(BASE|END)
(RELEASE)_(\d+)_(BASE|END)
^(THUNDERBIRD)_(\\d+)_0b(\\d+)_(BUILD\\d+|RELEASE)$ # beta tags
^(THUNDERBIRD)_(\\d+)(_\\d+)+_(BUILD\\d+|RELEASE)$ # release tags
https://hg-edge.mozilla.org/releases/comm-esr140/tags
(NIGHTLY)_(\d+)_(BASE|END)
(BETA)_(\d+)_(BASE|END)
(RELEASE)_(\d+)_(BASE|END)
(ESR)_(\d+)_(BASE|END)
^(THUNDERBIRD)_(\\d+)_0b(\\d+)_(BUILD\\d+|RELEASE)$ # beta tags
^(THUNDERBIRD)_(\\d+)(_\\d+)+esr_(BUILD\\d+|RELEASE)$ # esr tags
There was a problem hiding this comment.
Should there be a tag_pattern for comm-central?
It will get .+ to get all tags.
Do the tag_patterns only include tags from the corresponding git branch?
The logic is less smart^W^Wmore flexible: we need to explicitly list all the tag patterns that we want to go to a given repo. This is regardless of whether the commit is on a matching branch for that repo. In case it isn't (because we didn't write this config file correctly), Hg will ignore the tag, and it will simply not be created on the target repo.
There was a problem hiding this comment.
@coreycb Thanks for the updated mapping. I've pushed an updated config (note: it's only comments for now, as it doesn't apply to infra-testing, but it's good to capture and discuss this early nonetheless).
I have put in simpler (less specific) regexps, but I think they should achieve the same. Two things to note:
- most repos have some
^(NIGHTLY|BETA|RELEASE)tags, but they are inherited from merges or forks (e.g, esr140 doesn't have the most recent ones) - I can't include them all for the ESR, as we use the tags to determine the target repo. For Firefox, only the
esrversions are used, though I might had to add support for ESR_ here, too. I'm not completely sure how well this will work.
-> Is the ESR_nnn_BASE tag used in any downstream automation?
There was a problem hiding this comment.
-> Is the
ESR_nnn_BASEtag used in any downstream automation?
It doesn't look like it. @dandarnell can you check too?
cgsheeh
left a comment
cgsheeh
left a comment
There was a problem hiding this comment.
FYI there are whitespace-only changes in config-suite.toml in this PR, not sure if that was intentional.
| # | ||
| # MOZILLA-UNIFIED | ||
| # | ||
| # We don't sync to this repository, but we put it here first to fetch all |
There was a problem hiding this comment.
Perhaps we could build that into a separate config like refs_fetch_source instead of shoe-horning it into branch_mappings?
There was a problem hiding this comment.
That's a good idea! I'll file a bug.
https://bugzilla.mozilla.org/show_bug.cgi?id=2022092
Though, thinking more about it, maybe we don't need it so much, now that we have bundles setup for those repos, too.
Oh, I missed that... config-suite should be gone. Added to gitignore. |
config-suite.tomlto gitignore