hack: Keep 125.0.1 as a major version#1430
Merged
bhearsum merged 1 commit intomozilla-releng:mainfrom Apr 17, 2024
Merged
Conversation
Contributor
|
CONGRATULATIONS READER! READ BELOW TO SEE HOW TO TEST THIS PR IN JUST 10 EASY STEPS 😅 More seriously, here's how I tested this PR:
--- old
+++ new
│ --- old/1.0
├── +++ new/1.0
│ │ --- old/1.0/all.json
│ ├── +++ new/1.0/all.json
│ │ ├── Pretty-printed
│ │ │ @@ -11516,14 +11516,23 @@
│ │ │ "category": "dev",
│ │ │ "date": "2012-04-19",
│ │ │ "description": null,
│ │ │ "is_security_driven": false,
│ │ │ "product": "firefox",
│ │ │ "version": "12.0b6"
│ │ │ },
│ │ │ + "firefox-125.0.2": {
│ │ │ + "build_number": 3,
│ │ │ + "category": "stability",
│ │ │ + "date": "2024-04-17",
│ │ │ + "description": null,
│ │ │ + "is_security_driven": false,
│ │ │ + "product": "firefox",
│ │ │ + "version": "125.0.2"
│ │ │ + },
│ │ │ "firefox-13.0": {
│ │ │ "build_number": 1,
│ │ │ "category": "major",
│ │ │ "date": "2012-06-05",
│ │ │ "description": null,
│ │ │ "is_security_driven": false,
│ │ │ "product": "firefox",
│ │ --- old/1.0/firefox.json
│ ├── +++ new/1.0/firefox.json
│ │ ├── Pretty-printed
│ │ │ @@ -671,14 +671,23 @@
│ │ │ "category": "dev",
│ │ │ "date": "2012-04-19",
│ │ │ "description": null,
│ │ │ "is_security_driven": false,
│ │ │ "product": "firefox",
│ │ │ "version": "12.0b6"
│ │ │ },
│ │ │ + "firefox-125.0.2": {
│ │ │ + "build_number": 3,
│ │ │ + "category": "stability",
│ │ │ + "date": "2024-04-17",
│ │ │ + "description": null,
│ │ │ + "is_security_driven": false,
│ │ │ + "product": "firefox",
│ │ │ + "version": "125.0.2"
│ │ │ + },
│ │ │ "firefox-13.0": {
│ │ │ "build_number": 1,
│ │ │ "category": "major",
│ │ │ "date": "2012-06-05",
│ │ │ "description": null,
│ │ │ "is_security_driven": false,
│ │ │ "product": "firefox",
│ │ --- old/1.0/firefox_history_major_releases.json
│ ├── +++ new/1.0/firefox_history_major_releases.json
│ │ ├── Pretty-printed
│ │ │ @@ -1,14 +1,15 @@
│ │ │ {
│ │ │ "1.0": "2004-11-09",
│ │ │ "1.5": "2005-11-29",
│ │ │ "10.0": "2012-01-31",
│ │ │ "100.0": "2022-05-03",
│ │ │ "11.0": "2012-03-13",
│ │ │ "12.0": "2012-04-24",
│ │ │ + "125.0.2": "2024-04-17",
│ │ │ "13.0": "2012-06-05",
│ │ │ "14.0.1": "2012-07-17",
│ │ │ "15.0": "2012-08-28",
│ │ │ "16.0": "2012-10-09",
│ │ │ "17.0": "2012-11-20",
│ │ │ "18.0": "2013-01-08",
│ │ │ "19.0": "2013-02-19",
│ │ --- old/1.0/l10n
│ ├── +++ new/1.0/l10n
│ │ ├── file list
│ │ │ @@ -872,14 +872,15 @@
│ │ │ Firefox-124.0b4-build1.json
│ │ │ Firefox-124.0b5-build1.json
│ │ │ Firefox-124.0b6-build1.json
│ │ │ Firefox-124.0b7-build1.json
│ │ │ Firefox-124.0b8-build1.json
│ │ │ Firefox-124.0b9-build1.json
│ │ │ Firefox-125.0.1-build1.json
│ │ │ +Firefox-125.0.2-build3.json
│ │ │ Firefox-125.0b1-build1.json
│ │ │ Firefox-125.0b2-build1.json
│ │ │ Firefox-125.0b3-build1.json
│ │ │ Firefox-125.0b4-build1.json
│ │ │ Firefox-125.0b5-build1.json
│ │ │ Firefox-125.0b6-build1.json
│ │ │ Firefox-125.0b7-build1.json
│ │ │ --- old/1.0/l10n/index.html
│ │ ├── +++ new/1.0/l10n/index.html
│ │ │┄ 'html2text' not available in path.
│ │ │ @@ -881,14 +881,15 @@
│ │ │ <li><a href="Firefox-124.0b4-build1.json">Firefox-124.0b4-build1.json</a></li>
│ │ │ <li><a href="Firefox-124.0b5-build1.json">Firefox-124.0b5-build1.json</a></li>
│ │ │ <li><a href="Firefox-124.0b6-build1.json">Firefox-124.0b6-build1.json</a></li>
│ │ │ <li><a href="Firefox-124.0b7-build1.json">Firefox-124.0b7-build1.json</a></li>
│ │ │ <li><a href="Firefox-124.0b8-build1.json">Firefox-124.0b8-build1.json</a></li>
│ │ │ <li><a href="Firefox-124.0b9-build1.json">Firefox-124.0b9-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0.1-build1.json">Firefox-125.0.1-build1.json</a></li>
│ │ │ + <li><a href="Firefox-125.0.2-build3.json">Firefox-125.0.2-build3.json</a></li>
│ │ │ <li><a href="Firefox-125.0b1-build1.json">Firefox-125.0b1-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0b2-build1.json">Firefox-125.0b2-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0b3-build1.json">Firefox-125.0b3-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0b4-build1.json">Firefox-125.0b4-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0b5-build1.json">Firefox-125.0b5-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0b6-build1.json">Firefox-125.0b6-build1.json</a></li>
│ │ │ <li><a href="Firefox-125.0b7-build1.json">Firefox-125.0b7-build1.json</a></li> |
JohanLorenzo
approved these changes
Apr 17, 2024
Contributor
JohanLorenzo
left a comment
There was a problem hiding this comment.
See my comment above. I'm confident this hack does what we want. Let's get it landed while we handle a better solution in #1429.
Thanks Ben for taking care of it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a short term fix that should be quite safe to take. @JohanLorenzo has patches in the works to fix this more robustly.