Fix python3.14 compat for worker.py#1901
Merged
Eijebong merged 1 commit intomozilla-releng:mainfrom Mar 5, 2026
Merged
Conversation
`get_event_loop` doesn't work anymore to create a new event loop so we have to explicitly create one. The gather is useless since we're only running one consumer, and removing it fixes a bug with python 3.14 where we can't call gather without a running event loop anymore. This is basically the same as 3854e1f7d25233eadfb21a551d8e5ef99b9f64a3 and 99ef1499414fe997a63dbef7c2b62b9e8455d5ef in tooltool
jcristau
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_event_loopdoesn't work anymore to create a new event loop so we have to explicitly create one. The gather is useless since we're only running one consumer, and removing it fixes a bug with python 3.14 where we can't call gather without a running event loop anymore.This is basically the same as 3854e1f7d25233eadfb21a551d8e5ef99b9f64a3 and 99ef1499414fe997a63dbef7c2b62b9e8455d5ef in tooltool