Revert to using admin permission check when we can't determine an XPI type#1908
Open
Eijebong wants to merge 1 commit intomozilla-releng:mainfrom
Open
Revert to using admin permission check when we can't determine an XPI type#1908Eijebong wants to merge 1 commit intomozilla-releng:mainfrom
Eijebong wants to merge 1 commit intomozilla-releng:mainfrom
Conversation
… type If an XPI release is in progress but the commit for it is gone, we cannot determine the XPI type for it anymore and thus cannot cancel said release. In practice this shouldn't happen outside of staging but it does mean that at the moment we have a few releases there that we cannot cancel. When that is the case, fall back to an admin group check and log a warning.
jcristau
approved these changes
Mar 12, 2026
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Could do with a test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an XPI release is in progress but the commit for it is gone, we cannot determine the XPI type for it anymore and thus cannot cancel said release. In practice this shouldn't happen outside of staging but it does mean that at the moment we have a few releases there that we cannot cancel. When that is the case, fall back to an admin group check and log a warning.