Skip to content

Conversation

@tiftran
Copy link
Contributor

@tiftran tiftran commented Jan 30, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@tiftran tiftran requested a review from bendk January 30, 2026 18:56
@tiftran tiftran changed the title fix: remote cli-support from support component fix: remove cli-support from support component Jan 30, 2026
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. This looks great to me and should fix that build error. I had a suggestion about a comment, but I don't need to re-review this one.

} else {
"nimbus-mobile-experiments".to_string()
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment linking to the cli-support code and the reason why we can't import it directly.

@tiftran tiftran added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 51a70e8 Jan 30, 2026
14 checks passed
@tiftran tiftran deleted the nimbus-cli-fix branch January 30, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants