Add RustCrypto backend for crypto module/provider #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progdrasil
approved these changes
Oct 21, 2025
jschanck
approved these changes
Oct 21, 2025
Collaborator
jschanck
left a comment
jschanck
left a comment
There was a problem hiding this comment.
Seems reasonable! We should probably check in a lockfile to avoid the issue that you ran into with base64ct. But I can do that in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a pure-Rust backend, using the RustCrypto ecosystem of crates, for the
authenticatorlibrary as an easier-to-build and more maintainable solution for some non-Firefox users. OpenSSL is problematic to depend on for many applications out there.cargo test --no-default-features --features crypto_rustruns all the tests successfully on my local system using this branch.At 1Password we are looking to move off our very old version of
authenticator, which didn't have any cryptographic dependencies before, and update to the latest for CTAP2 support. OpenSSL is a no-go for us however and we obviously can't use NSS since we aren't Firefox, so this hopefully provides a bridge for the provider gap that exists onmaintoday.