Skip to content

Bump @mozilla-protocol/core from 16.0.1 to 18.0.0#110

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0
Closed

Bump @mozilla-protocol/core from 16.0.1 to 18.0.0#110
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 15, 2023

Bumps @mozilla-protocol/core from 16.0.1 to 18.0.0.

Release notes

Sourced from @​mozilla-protocol/core's releases.

18.0.0

What's Changed

  • css: Replace get-theme, type-scale functions and theme and type-scale maps with CSS Custom Properties. Sass variables added for legacy support
  • css: Migrates the sass @import with @use and @forward (#755).

Migration Tips

  • This version updates how we internally import SCSS files, from the @import syntax to @use and @forward
  • When importing lib at the head of your project you will use the with keyword instead of stating variables explicitly, like this:
@use '/assets/sass/protocol/includes/lib' with ($font-path: '/protocol/fonts');
  • To use the global namespace for protocol variables you will need to use the as keyword and assign to *:
@use '../includes/lib' as *;
  • if you don't use as you would access variables and mixins from the file using the filename as a namespace:
@use '../includes/lib';
.mzp-c-item {
@​include lib.text-title-md;
color: lib.$color-ink-80;
margin: lib.$spacing-lg 0;
}

  • For more information on the @use and @forward you can visit the offical SCSS documentation or the usage page on the Protocol documentation website

  • This version also moves from using the get-theme function to using css custom properties. A future version of protocol will depreciate both the get-theme and type-scale functions.

  • To migrate from get-theme or type-scale to CSS custom properties, follow this pattern:

  • From this:

.mzp-t-dark {
  background-color: get-theme('background-color-inverse');
  color: get-theme('body-text-color-inverse');
  line-height: type-scale('body-line-height');
}
  • to this:
  • (Note: if you need to support legacy browsers, place the CSS custom properties in a @supports flag and use sass variables as a fall back. Legacy browsers will always be served the default theme.)
.mzp-t-dark {
  background-color: $background-color-inverse;
  color: $body-text-color-inverse;
  line-height: $body-line-height;
</tr></table> 

... (truncated)

Changelog

Sourced from @​mozilla-protocol/core's changelog.

18.0.0

Features

  • css: Replace get-theme, type-scale functions and theme and type-scale maps with CSS Custom Properties. Sass variables added for legacy support
  • css: Migrates the sass @import with @use and @forward (#755).

Migration Tips

  • This version updates how we internally import SCSS files, from the @import syntax to @use and @forward
  • When importing lib at the head of your project you will use the with keyword instead of stating variables explicitly, like this:
@use '/assets/sass/protocol/includes/lib' with ($font-path: '/protocol/fonts');
  • To use the global namespace for protocol variables you will need to use the as keyword and assign to *:
@use '../includes/lib' as *;
  • if you don't use as you would access variables and mixins from the file using the filename as a namespace:
@use '../includes/lib';
.mzp-c-item {
@​include lib.text-title-md;
color: lib.$color-ink-80;
margin: lib.$spacing-lg 0;
}

  • For more information on the @use and @forward you can visit the offical SCSS documentation or the usage page on the Protocol documentation website

  • This version also moves from using the get-theme function to using css custom properties. A future version of protocol will depreciate both the get-theme and type-scale functions.

  • To migrate from get-theme or type-scale to CSS custom properties, follow this pattern:

  • From this:

.mzp-t-dark {
  background-color: get-theme('background-color-inverse');
  color: get-theme('body-text-color-inverse');
  line-height: type-scale('body-line-height');
}
  • to this:
  • (Note: if you need to support legacy browsers, place the CSS custom properties in a @supports flag and use sass variables as a fall back. Legacy browsers will always be served the default theme.)
.mzp-t-dark {
  background-color: $background-color-inverse;
  color: $body-text-color-inverse;
</tr></table> 

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by nathanbarrett24, a new releaser for @​mozilla-protocol/core since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 15, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch from 6d3295d to d0da358 Compare November 15, 2023 19:04
Copy link
Contributor

@rosahbruno rosahbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to require some changes before we can merge. These updates break the existing CSS and nothing gets pulled in. I will revisit this later.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch 2 times, most recently from 8ca977e to 62b64c2 Compare November 16, 2023 09:06
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch 2 times, most recently from aa4ff4f to cc35b97 Compare December 1, 2023 16:39
Bumps [@mozilla-protocol/core](https://github.com/mozilla/protocol) from 16.0.1 to 18.0.0.
- [Release notes](https://github.com/mozilla/protocol/releases)
- [Changelog](https://github.com/mozilla/protocol/blob/main/CHANGELOG.md)
- [Commits](mozilla/protocol@v16.0.1...v18.0.0)

---
updated-dependencies:
- dependency-name: "@mozilla-protocol/core"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch from cc35b97 to e693577 Compare December 13, 2023 06:57
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 15, 2024

Superseded by #140.

@dependabot dependabot bot closed this Jan 15, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mozilla-protocol/core-18.0.0 branch January 15, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant