When flattening don't treat null as an object#234
Merged
Conversation
Despite our best efforts we do allow `null` as a value in e.g. object metrics to be sent. That previously crashed the frontend as it tried to dive into `null` as if it was an object. It's not, despite everything `typeof null` wants to tell you. We handle that case explicitly now and just render `null` values as ... nothing. Fixes #233
travis79
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite our best efforts we do allow
nullas a value in e.g. object metrics to be sent.That previously crashed the frontend as it tried to dive into
nullas if it was an object.It's not, despite everything
typeof nullwants to tell you. We handle that case explicitly now and just rendernullvalues as ... nothing.Fixes #233