Use the gungraun benchmark framework to get reliable instruction count numbers on CI #3370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t numbers on CI This also moves it out of the main workspace, so it properly splits out the dependencies.
badboy
force-pushed
the
push-povlnvknxktp
branch
from
fbf64e7 to
18468cc
Compare
badboy
force-pushed
the
push-povlnvknxktp
branch
from
18468cc to
1f2612a
Compare
badboy
commented
Jan 9, 2026
| jobs: | ||
| bench: | ||
| name: Benchmarks | ||
| environment: ${{ github.ref_name == 'main' && 'production' || 'pull_request' }} |
Member
Author
There was a problem hiding this comment.
I plan on collecting the data and pushing that to another repository. That will require a secret (the push token). For security we split that out into the production environment, so the token is available when actually run on a push to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first refactoring of our benchmarks.
benchmarkcrate. That way it's separate from the Glean crates and doesn't interfere with the Rust version requirements or dependency requirements. We are a bit more free to use crates without propagating any vetting directly (plus those deps never show up in m-c then).I plan to collect those numbers over time and provide a dashboard so we have an (after-the-fact) overview of the performance.