Fix dimensions for newer social icons#93
Conversation
|
I think whichever size we choose, either 16x16 or 24x24, we should be consistent across all of them. I tend to include width and height in addition to viewBox so it still has a "natural" size when its viewed on its own. So maybe we should resize Mastodon to 16 x 16 and keep the dimension attributes, and do the same for the others that are 24 x 24. |
|
Even better! I think the original icons' 16px form factor w/ explicit dimensions is a good idea to match for consistency — I'll make all the newer social icons that size too. I originally didn't want to resize or otherwise touch the shapes so this felt like a quick fix, but it's sorted out downstream for now with bg contain so there's no pressure and we can fixup all of them… |
|
@janbrasna What is the state of this draft? |
The SVG icons either need to be at 16px (like fx, fb, ig, gh, pocket…) or if 24px or any other size (e.g. spotify, tiktok & mastodon) only the
viewBoxwithoutwidthandheightmust be present to work in bedrock footerbackground-imagein WebKit.Mastodon SVG icons are the only ones in 24px that also declare dimensions, making migration to protocol_assets buggy:
(PoC: janbrasna/bedrock@5653020)
Leaving out the dimensions fixes this and enables removal of the local overrides in footer.