Skip to content

Conversation

@AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Jan 3, 2026

Fixes #2532

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.08%. Comparing base (760a109) to head (4cdefd1).

Files with missing lines Patch % Lines
src/compiler/msvc.rs 76.92% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files          64       64           
  Lines       35432    35457   +25     
=======================================
+ Hits        25186    25204   +18     
- Misses      10246    10253    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* support forward slash as an output dir marker
* add multiple file extensions test for output dir specification
@AJIOB AJIOB force-pushed the fix-2532-out-dir branch from 286e62b to 4cdefd1 Compare January 3, 2026 10:41
@sylvestre sylvestre merged commit f32dc80 into mozilla:main Jan 5, 2026
54 checks passed
@AJIOB AJIOB deleted the fix-2532-out-dir branch January 5, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sccache + MSVC: output dir specification doesn't work as expected

3 participants