Skip to content

Color aggregate lines the same across versions #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonco3 wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

Color aggregate lines the same across versions #631

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
602c822
Use the same line color for aggregates between versions
jonco3 Nov 4, 2019
07d5417
Rename Line.getStateString to Line.getColorId as this is the only use
jonco3 Nov 4, 2019
593e846
Merge remote-tracking branch 'upstream/gh-pages' into gh-pages
jonco3 Dec 10, 2021
2628000
Merge branch 'mozilla:gh-pages' into gh-pages
jonco3 Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions new-pipeline/src/evo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,12 +913,12 @@ var Line = (function () {
this.values = values || [];

// Assign a color to the line
var stateString = this.getStateString();
if (!lineColors.hasOwnProperty(stateString)) {
var colorId = this.getColorId();
if (!lineColors.hasOwnProperty(colorId)) {
goodColorIndex = (goodColorIndex + 1) % goodColors.length;
lineColors[stateString] = goodColors[goodColorIndex];
lineColors[colorId] = goodColors[goodColorIndex];
}
this.color = lineColors[stateString];
this.color = lineColors[colorId];
}

Line.prototype.getVersionString = function Line_getVersionString() {
Expand All @@ -933,8 +933,8 @@ var Line = (function () {
}
return this.aggregate + " " + this.measure + " for " + getHumanReadableChannelName(this.channelVersion);
};
Line.prototype.getStateString = function Line_getTitleString() {
return this.aggregate + "/" + this.measure + "/" + getHumanReadableChannelName(this.channelVersion).replace(' ', '-');
Line.prototype.getColorId = function Line_getColorId() {
return this.aggregate + "/" + this.measure;
};

return Line;
Expand Down