chore(p256-m): add explicit uint16_t cast in u32_muladd64#2
Open
stgloorious wants to merge 1 commit intompg:masterfrom
Open
chore(p256-m): add explicit uint16_t cast in u32_muladd64#2stgloorious wants to merge 1 commit intompg:masterfrom
stgloorious wants to merge 1 commit intompg:masterfrom
Conversation
When splitting 32-bit x and y values into lower and higher
16-bit values, make sure to explicitly cast the higher
part to uint16_t as well. This fixes the compiler warning:
src/common/crypto_p256.c: In function ‘u32_muladd64’:
src/common/crypto_p256.c:264:29: warning: conversion from
‘uint32_t’ {aka ‘unsigned int’} to ‘uint16_t’ {aka ‘const
short unsigned int’} may change value [-Wconversio]
264 | const uint16_t xh = x >> 16;
| ^
src/common/crypto_p256.c:265:29: warning: conversion from
‘uint32_t’ {aka ‘unsigned int’} to ‘uint16_t’ {aka ‘const
short unsigned int’} may change value [-Wconversio]
265 | const uint16_t yh = y >> 16;
| ^
Signed-off-by: Stefan Gloor <stefan.gloor@siemens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When splitting 32-bit x and y values into lower and higher 16-bit values, make sure to explicitly cast the higher part to
uint16_tas well. This fixes the compiler warning: