Skip to content

Explicitly specifies the logo's width and height#29

Open
zgosalvez wants to merge 2 commits intompociot:masterfrom
zgosalvez:fix-logo-size
Open

Explicitly specifies the logo's width and height#29
zgosalvez wants to merge 2 commits intompociot:masterfrom
zgosalvez:fix-logo-size

Conversation

@zgosalvez
Copy link

This allows us to use a logo that is 2x, i.e., 460 x 104, which will look better on retina displays (Macs).

@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #29 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files           2        2           
  Lines          61       61           
=======================================
  Hits           54       54           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7dc266...bb50746. Read the comment docs.

@zgosalvez
Copy link
Author

I actually prefer #17 instead of this. Sorry, I just saw that now. I can close this if @mpociot pulls that. I hope he does since the low-resolution logo is really ugly on HiDPI displays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants