Adds space initialization and XDG compliant configuration #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the emergence of the abstraction pattern used within the core library. Idea is to always work from a trait which defines the interface, thus allowing a default implemenation to be implemented while still being open to easily add new implemenations and proper unit testing without the hassle of too much mockery.
Also allowed unused license execption, since it only originates from the project's crates.
The path locator will be implemented once the configuration system is in place.
… space default impl
Also introduces the command trait and common global arguments for each sub-command.
Previously when the given path did not exist a error was reported.
Currently works with two files: - ~/.config/flow/config.json > Holds all user defined global settings - ~/.config/flow/spaces.json > Holds registered spaces and currently active one via `flow open` CLI
Also includes some minor refactoring to make the code more readable. Common arguments like Output and Space no longer control the logging behaviour based on the given arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds space initialization and XDG compliant configuration.
Type of Change
Testing
cargo test --workspace --all-features