Refactor: adds errors and common crate #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to link to errors and their explenations via miette. It also allows to share errors between crates.
Factored out the existing Path extension trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To streamline error management a new crate that just holds error definitions has been added. This centralizes the error definitions, making it easier for linked error descriptions later.
It also moved common code to a shared crate. Currently there is only one extension trait present.
In addition to the above, all existing code comments have been revised.
Type of Change
Changes Made
flow-errorscrateflow-commoncrateTesting
cargo test --workspace --all-features