Skip to content

Mark factory methods as static to preven warnings. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark factory methods as static to preven warnings. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Text/Wiki.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ public function __construct($rules = null)
* in further calls it will be effectively ignored.
* @return &object a reference to the Text_Wiki unique instantiation.
*/
public function &singleton($parser = 'Default', $rules = null)
public static function &singleton($parser = 'Default', $rules = null)
{
static $only = array();
if (!isset($only[$parser])) {
Expand All @@ -480,7 +480,7 @@ public function &singleton($parser = 'Default', $rules = null)
* {@see Text_Wiki::singleton} for a list of rules
* @return Text_Wiki a Parser object extended from Text_Wiki
*/
public function factory($parser = 'Default', $rules = null)
public static function factory($parser = 'Default', $rules = null)
{
$class = 'Text_Wiki_' . $parser;
$file = str_replace('_', '/', $class).'.php';
Expand Down