add support addtional include and link folder, and /MT /MD options, and a few error handlings#4
Open
zhutoulala wants to merge 3 commits intomrpi:masterfrom
Open
add support addtional include and link folder, and /MT /MD options, and a few error handlings#4zhutoulala wants to merge 3 commits intomrpi:masterfrom
zhutoulala wants to merge 3 commits intomrpi:masterfrom
Conversation
zhutoulala
changed the title
Author
|
also refactor the code a bit by moving most code out of main |
Author
|
Hi @mrpi, have you got a chance to take a look at this PR? |
pvanoppen2
reviewed
Jan 31, 2019
| void cmake::writeGeneratedNote(std::ostream& os) | ||
| { | ||
| os << "#" << std::endl; | ||
| os << "# This file was genared by proj2cmake and will be overwritten on it's next run!" << std::endl; |
pvanoppen2
reviewed
Jan 31, 2019
| fs::path confFile = "cmake_conf"; | ||
| confFile /= (solution.name + ".cmake"); | ||
|
|
||
| //os << "IF(EXISTS \"${" << solution.name << "_SOURCE_DIR}/cmake_conf/" << solution.name << ".cmake\")" << std::endl; |
There was a problem hiding this comment.
To leave commented out code is a bad practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issues:
open read only solution file failed
INCLUDE .cmake syntax error on Windows due to backslash in the path
Parsing driver projects throws exceptions