docs: redesign test subcommand as headless mode#46
Merged
Conversation
Key changes:
- HTTP server on port 8080 instead of stdin/stdout JSON
- POST /input returns both render_url and raw ANSI
- GET /render/latest.png for easy browser viewing
- GET /render/{timestamp}.png for specific renders
- Larger default terminal size (120x30)
- just recipes for starting test server
'headless' better describes running the TUI without a terminal, which is the standard term (like headless browsers).
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
|
Changes Requested
Summary of Changes
Overall Feedback
Please update the spec with the requested changes and ping me when ready for another review. Thanks! 🎯 |
- /render/latest now redirects (302) to timestamped URL - /state includes render_url and ansi in response
Update run-docker to bind port 8080 for headless subcommand instead of adding new recipes.
Examples: - just input key j - just input type "hello world" - just input resize 40 160
- Fix terminal size references to 160x40 - Add task for error responses on invalid actions - Clarify initial render happens on startup - Clarify input recipe wraps curl
- Bind to localhost (127.0.0.1) by default - Add --bind flag to optionally expose to network - Document lack of authentication and CORS - Note that server is for local dev/testing only
- Add --max-renders flag (default: 100) to prevent unbounded memory growth - Implement FIFO eviction when limit reached - Clarify that ansi field contains raw View() output with all escape sequences
Contributor
Author
|
Wow! surprisingly on-point feedback for the code review bot! |
Pertempto
commented
Jan 8, 2026
Reduced verbosity while keeping all essential information: - Problem section removed (context is clear) - Usage examples consolidated - Design decisions summarized - Task list unchanged
- Add backticks around all endpoint references - Unify GET /state and POST /input response formats - Update creation date to January 8
- Must use FiraCode Nerd Font for powerline symbol support - Add task for configuring bubbletea ANSI output to non-tty
This comment was marked as resolved.
This comment was marked as resolved.
Address clarifying questions from implementation: - Key format uses tea.KeyMsg.String() (enter, esc, ctrl+c, etc.) - Mode values from CurrentMode.Name (list, start, help, stats) - Timestamp format with all dashes for URL safety - Link to Ghostty source for color palette reference
- Add full 16-color palette table with hex values - Specify pure black (#000000) as default/background color - Remove external Ghostty reference
Contributor
Author
addressed with two newest commits |
bambam955
reviewed
Jan 9, 2026
bambam955
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had shelley implement the test subcommand, but it turned out to actually be a bit inconvenient for the agent to access the image files from the temporary directory.
It works much better if we just scrap the temporary directory output and the stdin/stdout system. Instead just serve headless mode through a simple HTTP server.
I also found a better name to describe what this actually is -
headlessrather thantest.