Fix MaximumLength crash with datasets having >8 character states

[Copilot]

MaximumLength(inapplicable.phyData[["Vinther2008"]]) crashed with status -1073741819 (access violation). The Vinther2008 dataset has 10 character states (0-9), triggering two bugs.

Bugs Fixed

• Raw overflow in MaximumLength.numeric(): as.raw(seq_len(nToken)) silently truncates values >255. With 10 states, nToken = 1023, causing incorrect bit operations.

  # Before: overflows when nToken > 255
  bitTokens <- as.raw(seq_len(nToken))
  nonIntersect <- outer(bitTokens, bitTokens, `&`) == 00
  
  # After: uses integer bitwise ops
  bitTokens <- seq_len(nToken)
  nonIntersect <- outer(bitTokens, bitTokens, bitwAnd) == 0L

• Incorrect indexing in MinimumLength.numeric(): tokens[, tokens[!squish], ...] is wrong—!squish on a positive integer returns FALSE. Fixed to tokens[, !tokens[squish, ], ...].

Guards Added

• Check length(counts) > 0 before processing
• Error for >30 states (would overflow integer capacity)

Tests

• Regression tests for >8 states and Vinther2008 dataset specifically

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• cloud.r-project.org
  • Triggering command: /usr/lib/R/bin/exec/R /usr/lib/R/bin/exec/R --no-echo --no-restore -e ~n~options(repos~+~=~+~c(CRAN~+~=~+~'REDACTED'))~n~install.packages(c('TreeTools',~+~'ape',~+~'Rcpp',~+~'cli',~+~'cluster',~+~'fastmap',~+~'fastmatch',~+~'fs',~+~'future',~+~'promises',~+~'protoclust',~+~'Rdpack',~+~'shiny',~+~'shinyjs (dns block)
• cran.r-project.org
  • Triggering command: /usr/lib/R/bin/exec/R /usr/lib/R/bin/exec/R --no-echo --no-restore -e install.packages(c('devtools',~+~'testthat'),~+~repos='REDACTED',~+~dependencies=TRUE) (dns block)
• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Crash in MaximumLength()</issue_title>
<issue_description>MaximumLength(inapplicable.phyData[["Vinther2008"]]) Exited with status -1073741819.

Tasks:

• Diagnose the cause of the crash
• Fix the underlying bug
• If necessary, place guards so that similar issues fail politely
  </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Crash in MaximumLength() #203

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.