Skip to content

Move-safe ClusterTable#244

Merged
ms609 merged 1 commit intomainfrom
move-safe-ClusterTable
Feb 5, 2026
Merged

Move-safe ClusterTable#244
ms609 merged 1 commit intomainfrom
move-safe-ClusterTable

Conversation

@ms609
Copy link
Owner

@ms609 ms609 commented Feb 5, 2026

Use index rather than pointer

@ms609 ms609 merged commit 493ff48 into main Feb 5, 2026
16 of 19 checks passed
@ms609 ms609 deleted the move-safe-ClusterTable branch February 5, 2026 11:43
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance benchmark results

Call Status Change Time (ms)
as.Splits(bigTrees) ⚪ NSD 2.8% 23.2 →
21.6, 23
as.Splits(someTrees) ⚪ NSD -0.04% 11.5 →
11.6, 11.2
Consensus(forest1k.888, check = FALSE) ⚪ NSD -2.89% 95.4 →
100, 95.9
Consensus(forest201.80, check = FALSE) ⚪ NSD -1.65% 4.02 →
4.1, 4.08
Consensus(forest21.260, 0.5, FALSE) ⚪ NSD -2.67% 1.21 →
1.26, 1.23
Consensus(forest21.260) ⚪ NSD -1.7% 1.21 →
1.24, 1.22
Consensus(forestMaj, 0.5, FALSE) ⚪ NSD -1.6% 2.95 →
3, 2.97
DropTip(tr2000, 5) ⚪ NSD -1.27% 20.4 →
20.8, 20.5
DropTip(tr80, 5) ⚪ NSD -1.81% 0.104 →
0.106, 0.104
DropTip(unlen2k, 5) ⚪ NSD 0.84% 0.21 →
0.209, 0.208
DropTip(unlen80, 5) ⚪ NSD -1.98% 0.0404 →
0.0416, 0.0408
lapply(bigSplits, as.phylo) 🟣 ~same 1.19% 31.1 →
30.8, 30.7
lapply(someSplits, as.phylo) ⚪ NSD -1.63% 14.1 →
14.5, 14.1
PathLengths(tr2000, full = TRUE) ⚪ NSD -0.17% 19.5 →
19.5, 20
PathLengths(tr80, full = TRUE) 🟢 Faster! 71.17% 0.102 →
0.102, 0.0293
PathLengths(tr80Unif, full = TRUE) ⚪ NSD 1.77% 0.0317 →
0.0315, 0.0311
RootTree(tr2000, 5) ⚪ NSD 4.72% 0.393 →
0.373, 0.374
RootTree(tr80, c("t3", "t36")) ⚪ NSD 1.15% 0.0711 →
0.0705, 0.0701
RootTree(tr80, "t3") ⚪ NSD 0.78% 0.0502 →
0.0502, 0.0495
RootTree(tr80, "t30") ⚪ NSD 1.78% 0.0512 →
0.0504, 0.0502
RootTree(unlen2k, 5) ⚪ NSD -1.09% 0.331 →
0.336, 0.334
RootTree(unlen80, c("t3", "t36")) ⚪ NSD 2.53% 0.0653 →
0.0636, 0.0638
RootTree(unlen80, "t3") ⚪ NSD 0.05% 0.0437 →
0.0437, 0.0436
RootTree(unlen80, "t30") ⚪ NSD 1.16% 0.0442 →
0.0441, 0.0433
TreeDist::RobinsonFoulds(forest201.80) ⚪ NSD 0.27% 15.4 →
15.5, 15.3
TreeDist::RobinsonFoulds(forest21.888) ⚪ NSD 0.09% 3.24 →
3.22, 3.26
TreeTools:::path_lengths(tr80$edge, tr80$edge.length, FALSE) ⚪ NSD -0.62% 0.0917 →
0.0918, 0.0927
TreeTools:::postorder_order(bal40) ⚪ NSD 0.6% 0.00166 →
0.00164, 0.00166
TreeTools:::postorder_order(bal40k) ⚪ NSD 0.19% 0.442 →
0.441, 0.442
TreeTools:::postorder_order(dbal40) ⚪ NSD 1.19% 0.00175 →
0.00172, 0.00174
TreeTools:::postorder_order(dbal40k) ⚪ NSD -0.27% 2.14 →
2.15, 2.14
TreeTools:::postorder_order(dpec40) ⚪ NSD 1.18% 0.00254 →
0.00251, 0.00251
TreeTools:::postorder_order(dpec40k) ⚪ NSD -0.32% 3410 →
3430, 3420
TreeTools:::postorder_order(drnd80) ⚪ NSD -0.51% 0.00395 →
0.00401, 0.00394
TreeTools:::postorder_order(nbal40) ⚪ NSD 0.96% 0.0021 →
0.00207, 0.00209
TreeTools:::postorder_order(nbal40k) ⚪ NSD 0.05% 2.18 →
2.17, 2.18
TreeTools:::postorder_order(npec40) ⚪ NSD 1.41% 0.00285 →
0.00282, 0.0028
TreeTools:::postorder_order(npec40k) ⚪ NSD 0.51% 3420 →
3420, 3360
TreeTools:::postorder_order(nrnd80) ⚪ NSD -0.89% 0.0045 →
0.00457, 0.00451
TreeTools:::postorder_order(pec40) ⚪ NSD 2.37% 0.00168 →
0.00164, 0.00163
TreeTools:::postorder_order(pec40k) ⚪ NSD -1.98% 0.431 →
0.438, 0.441
TreeTools:::postorder_order(rnd80) ⚪ NSD 1.37% 0.00211 →
0.00212, 0.00206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant