Conversation
Contributor
Author
|
I still work on the serialization. My question is if the general design is welcomed or if there are better ideas. |
The map data type has a special proto syntax.
The serialization of
map<key_type, value_type> map_field = N;
is backward compatible to
message MapFieldEntry {
key_type key = 1;
value_type value = 2;
}
repeated MapFieldEntry map_field = N;
The option `[packed = true]` is not allowed on map fields.
Owner
|
I have been away from dlang for a while (basically since graduating college), but I took a look at your design and it seems like a good starting point. If you're still open to developing this, I can take a look once serialization is implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map data type has a special proto syntax.
The serialization of
is backward compatible to
The option
[packed = true]is not allowed on map fields.