Skip to content

Conversation

@The4codeblocks
Copy link
Contributor

@The4codeblocks The4codeblocks commented Jan 1, 2026

minetestcore
use vector functions wherever possible (to allow other mods to wrap them)
facilitate function wrapping in some other places

Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fat pr - conditional on the tests being fixed

Image

S-S-X
S-S-X previously requested changes Jan 1, 2026
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wsor4035
Copy link

wsor4035 commented Jan 1, 2026

(still isnt passing).

additionally given the engine is on 5.14 now, dont exactly care about 5.0, especially since it limits you to formspec v1 (which has terrible cords), and before 5.4 use texture alpha is a bool instead of a mode, etc. i would wager a guess that if you looked through the code you would find something that already breaks the works on 5.0 expectation

@The4codeblocks
Copy link
Contributor Author

now it's passing

@S-S-X S-S-X dismissed their stale review January 2, 2026 02:30

Works now to the spec though I do agree we probably should increase min required version at cdb (and also add it to conf file). And then of course also increment mineunit engine version for later core libs.

My formal approval is just waiting for better actual review, it seems all good to me just did not have time (and good enough hardware to go through actual changes if there was any).

@wsor4035 wsor4035 merged commit 5da37b5 into mt-mods:master Jan 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants