-
Notifications
You must be signed in to change notification settings - Fork 31
modernize #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S-S-X
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
(still isnt passing). additionally given the engine is on 5.14 now, dont exactly care about 5.0, especially since it limits you to formspec v1 (which has terrible cords), and before 5.4 use texture alpha is a bool instead of a mode, etc. i would wager a guess that if you looked through the code you would find something that already breaks the works on 5.0 expectation |
|
now it's passing |
Works now to the spec though I do agree we probably should increase min required version at cdb (and also add it to conf file). And then of course also increment mineunit engine version for later core libs.
My formal approval is just waiting for better actual review, it seems all good to me just did not have time (and good enough hardware to go through actual changes if there was any).

minetest→coreuse
vectorfunctions wherever possible (to allow other mods to wrap them)facilitate function wrapping in some other places