Apply width, height, left, and top params to newStream#28
Open
ianjennings wants to merge 1 commit intomuaz-khan:masterfrom
Open
Apply width, height, left, and top params to newStream#28ianjennings wants to merge 1 commit intomuaz-khan:masterfrom
ianjennings wants to merge 1 commit intomuaz-khan:masterfrom
Conversation
The code from examples here don't work properly as the positional properties don't carry to `newStream` on creation. ```js screenStream.fullcanvas = true; screenStream.width = screen.width; // or 3840 screenStream.height = screen.height; // or 2160 cameraStream.width = parseInt((20 / 100) * screenStream.width); cameraStream.height = parseInt((20 / 100) * screenStream.height); cameraStream.top = screenStream.height - cameraStream.height; cameraStream.left = screenStream.width - cameraStream.width; ``` This pull ensures the positional properties of the given stram map to the `newStream`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code from examples here don't work properly as the positional properties don't carry to
newStreamon creation.This pull ensures the positional properties of the given stram map to the
newStream.