Conversation
lonerapier
force-pushed
the
feat/generic-field
branch
from
e8b4601 to
1348212
Compare
Autoparallel
left a comment
Autoparallel
left a comment
There was a problem hiding this comment.
Great work!!!
Feel free to take my suggestions or not.
There was a problem hiding this comment.
can you put all the versions for each crate to x.y.z as opposed to x.y or x. This will try to enforce a stricter version.
There was a problem hiding this comment.
While we're at it, set default features to false where you can too.
There was a problem hiding this comment.
That and you could likely add a release profile here to make this a bit faster.
There was a problem hiding this comment.
done all of them.
lonerapier
force-pushed
the
feat/generic-field
branch
from
2ef0be9 to
b392242
Compare
lonerapier
force-pushed
the
feat/generic-field
branch
from
b392242 to
5db05d8
Compare
Autoparallel
left a comment
Autoparallel
left a comment
There was a problem hiding this comment.
Looks good to me.
If you want to publish to crates, then you should! Would love to be an author with you :)
Cargo.toml
Outdated
| name = "sharks" | ||
| version = "0.5.0" | ||
| authors = ["Aitor Ruano <codearm@pm.me>"] | ||
| name = "gf256sss" |
There was a problem hiding this comment.
While we're at it, set default features to false where you can too.
There was a problem hiding this comment.
That and you could likely add a release profile here to make this a bit faster.
lonerapier
force-pushed
the
feat/generic-field
branch
from
73c1a26 to
0971d4d
Compare
|
All comments addressed. Merging!! |
2 participants
Adds:
gf256sss