Lint and vet #48
Open
Lint and vet #48
+577
−521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g coding standards
…nt with Golang coding standards
actown
suggested changes
Apr 12, 2020
Contributor
actown
left a comment
actown
left a comment
There was a problem hiding this comment.
Can you please remove pkg/mumbleproto/Mumble.pb.go from the PR? This file should be generated from the generate script within the mumbleproto directory.
delthas
reviewed
May 4, 2020
| // Send permission denied by type | ||
| func (c *Client) sendPermissionDeniedType(denyType mumbleproto.PermissionDenied_DenyType) { | ||
| c.sendPermissionDeniedTypeUser(denyType, nil) | ||
| func (client *Client) sendPermissionDeniedType(denyType mumbleproto.PermissionDenied_DenyType) { |
delthas
reviewed
May 4, 2020
| // Merge the contents of a frozen User into an existing user struct. | ||
| func (u *User) Unfreeze(fu *freezer.User) { | ||
| // Unfreeze will merge the contents of a frozen User into an existing user struct. | ||
| func (user *User) Unfreeze(fu *freezer.User) { |
delthas
reviewed
May 4, 2020
| func (s *Server) SendUDP(buf []byte, addr *net.UDPAddr) (err error) { | ||
| _, err = s.udpconn.WriteTo(buf, addr) | ||
| // SendUDP will send the content of buf as a UDP packet to addr. | ||
| func (server *Server) SendUDP(buf []byte, addr *net.UDPAddr) (err error) { |
delthas
reviewed
May 4, 2020
| } | ||
|
|
||
| // Type txReader imlpements a checksumming reader, intended | ||
| // txReader imlpements a checksumming reader, intended |
Same for |
|
Squashing all commits would also make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all go vet issues and golint issues identified in the code base (except for the ones in the generated code). These issues are all minor changes to naming or to structure to make them conform to Golang coding standards.