Skip to content

Feat: Add Super Mario Bros. clone game#19

Open
muumuu8181 wants to merge 1 commit intomainfrom
feat-mario-game-16595800468519361746
Open

Feat: Add Super Mario Bros. clone game#19
muumuu8181 wants to merge 1 commit intomainfrom
feat-mario-game-16595800468519361746

Conversation

@muumuu8181
Copy link
Owner

This change introduces a fully functional Super Mario Bros. clone game built with HTML5 Canvas and JavaScript. It features player movement, jumping, collision detection, enemies, and a level layout inspired by World 1-1. The game is accessible via public/mario.html. Instructions have been added to the README.


PR created automatically by Jules for task 16595800468519361746 started by @muumuu8181

- Create `public/mario.html` as the game entry point.
- Implement game logic in `public/js/mario.js` using HTML5 Canvas.
- Add styles in `public/css/mario.css`.
- Update `README.md` with instructions on how to play the game.

Co-authored-by: muumuu8181 <87556753+muumuu8181@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5032ca6fc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

" ",
" ",
" ",
" ??? G ",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move goal to a reachable position

The game’s win path is currently blocked because completion requires colliding with G (Game.update() sets gameWon only on this.player.checkCollision(goal)), but in this layout G is placed high at column 87 while the same column is a solid vertical wall of # blocks below it; with the configured jump physics (JUMP_FORCE = -10, GRAVITY = 0.5), the player cannot reach the goal hitbox at that location, so gameWon never triggers in normal play.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant