Open
Conversation
Pylint shows these coding errors:
livefs_edit/context.py:235:8:
E0401: Unable to import 'deb822' (import-error)
C0415: Import outside toplevel (deb822.Deb822)
(import-outside-toplevel)
'deb822' can be imported from 'debian'.
Fixes: 4d5ff31 ("rewrite get_suite in an excessively fancy way")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Owner
|
The reason for doing it this way was to avoid python3-debian being a requirement for uses that did not need it. I don't know how relevant that is really -- but maybe you could add a try: / except ImportError: around the top level import? |
Contributor
Author
|
The dependency is clearly stated in README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylint shows these coding errors:
'deb822' can be imported from 'debian'.
Fixes: 4d5ff31 ("rewrite get_suite in an excessively fancy way")