Skip to content

Conversation

@RiRe
Copy link

@RiRe RiRe commented Apr 17, 2025

No description provided.

@mxroute
Copy link
Owner

mxroute commented Apr 18, 2025

You are correct, but I believe it's actually a mistake in the logic. It seems that after loading the mxwebmail TXT record, we're setting it as imap_host regardless of it's presence on the whitelist. Which was actually the reason for that line, but I never followed through. Going to test a bit to confirm that I'm not going back and reading the code wrong, that I'm not forgetting something, and see what the right next move is.

@RiRe
Copy link
Author

RiRe commented Apr 18, 2025

The whitelist is checked in the other method. You actually resolve the hostname two times currently. I checked that before, because I also suspected that missing check.

@RiRe
Copy link
Author

RiRe commented Apr 18, 2025

if (in_array($txt_host_ip, $whitelisted_ips)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants