Merged
Conversation
Add a complete testing infrastructure with GitHub Actions CI workflow. Changes: - Add GitHub Actions workflow testing on Python 3.9-3.14 - Configure ruff with proper linting rules (E, F, B, UP, S) - Add pytest configuration in pyproject.toml - Add test dependencies: pytest-cov, pytest-mock - Create comprehensive test suite with 30+ test cases covering: - Utility functions (listdir, hilite, get_branch) - GitHub API integration (query_repos) - All perform_* functions with mocking - Edge cases (non-git directories, files vs directories) - Add pytest fixtures for mocking subprocess, git repos, and API responses - Update .gitignore to exclude local config files The test suite provides ~80% code coverage and ensures code quality before making any refactoring changes. CI runs on all supported Python versions. Note: Kept isort separate from ruff as it uses force_alphabetical_sort which ruff doesn't support.
Member
Author
CI FailuresThe GitHub Actions CI is failing because ruff is catching code quality and security issues in the existing code: Issues found:
Will fix the code to pass ruff checks. |
56213f9 to
53e4263
Compare
- Convert percent formatting to f-strings (UP031) - Fix shell=True vulnerability in get_branch() (S602) - Add noqa comments for acceptable subprocess and urlopen usage - Fix infinite loop in query_repos tests by properly simulating pagination ending All tests now pass (30/30) with 91% code coverage.
53e4263 to
2f1fae0
Compare
Member
Author
Makefile enhancements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive testing infrastructure and GitHub Actions CI workflow.
Changes
Testing Infrastructure:
CI/CD:
Code Quality Configuration:
Housekeeping:
Test Coverage
The test suite covers: