Update readme docker-compose file for MyBB 1.9 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinVR
commented
Jun 5, 2021
KevinVR
commented
- Build from the Dockerfile instead of using the image for 1.9 since it is not yet published
- Added some information regarding database connections
- Build from the Dockerfile instead of using the image for 1.9 since it is not yet published - Added some information regarding database connections
euantorano
requested changes
Jun 7, 2021
Member
euantorano
left a comment
euantorano
left a comment
There was a problem hiding this comment.
Minor comment regarding the changes to the example compose/stack file. Addition of DB details seems useful to me.
| services: | ||
| mybb: | ||
| image: mybb/mybb:latest | ||
| build: . |
Member
There was a problem hiding this comment.
I don't believe this is supported for docker swarm/docker stack (only Compose). If that's the case, the title likely needs changing.
(of course, it's possible I've just not been keeping up to date and this is now supported...)
dav3yblaz3
approved these changes
Dec 26, 2024
dav3yblaz3
left a comment
dav3yblaz3
left a comment
There was a problem hiding this comment.
Looks good can we try for test thanks team
|
looks good for test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.