Open
Conversation
cf29c3b to
764bf33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis-CI is no more, replaced by GitHub actions which are free for OSS projects like pyformat.
I propose replacing the old
.travis.ymlwith an equivalent github action workflow. Small differences:runs-on: ubuntu-latestwhich isubuntu24.04, cf. python versions-manifest.jsonubuntu22.04for 3.7, all the way toubuntu18.04for 3.4), but probably not worth the headachepip install -e .instead of the deprecated and brokenpython setup.py installThe github action is configured to be run:
It only runs on linux. It could be configured to also run on windows/macos but I don't think it matters for this project.
Example run: https://github.com/StalkR/pyformat/actions/runs/19685648150
All builds and tests pass, except 3.14 which is currently broken, and for which I've sent a separate PR to fix: #14 (once merged, the tests are expected to pass).
I also updated the
README.rstto update the build badge (from Travis-CI to GitHub Actions) and add the coveralls badge.Future work could be a GitHub Action to automate publishing the package to PyPI.
Thank you for maintaining this project and I hope this helps!