Devel

.gitignore

@@ -1,2 +1,3 @@
 /vendor
 /composer.lock
+.idea

composer.json

@@ -17,5 +17,18 @@
 		"nette/neon": "~2.3",
 		"latte/latte": "~2.3"
 	},
+	"require-dev": {
+		"nette/tester": "1.4.0"
+	},
+	"autoload": {
+		"classmap": [
+			"src/"
+		]
+	},
+	"autoload-dev": {
+		"classmap": [
+			"tests/"
+		]
+	},
 	"bin": ["src/code-checker.php"]
 }

src/CodeCheckers/EntityChecker.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace CodeCheckers;
+
+use Nette\Object;
+use Nette\Utils\Strings;
+
+
+
+class EntityChecker extends Object
+{
+
+	public static function createAnnotationsChecker()
+	{
+		return function ($checker, $s) {
+			if (!$checker->is('php')) {
+				return;
+			}
+
+			if (Strings::contains($s, '@ORM\Entity') && !Strings::contains($s, '@ORM\Entity(')) {
+				$checker->fix('Missing Entity`()`');
+				$s = str_replace('@ORM\Entity', '@ORM\Entity()', $s);
+			}
+
+			if (Strings::contains($s, '@ORM\Table()')) {
+				$checker->fix('Missing `name="table_name"`');
+				$s = str_replace('@ORM\Table()', '@ORM\Table(name="")', $s);
+			}
+
+			if (Strings::contains($s, '@ORM\Table') && !Strings::contains($s, '@ORM\Table(')) {
+				$checker->fix('Missing `name="table_name"`');
+				$s = str_replace('@ORM\Table', '@ORM\Table(name="")', $s);
+			}
+
+			return $s;
+		};
+	}
+}

src/CodeCheckers/Html5Checker.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace CodeCheckers;
+
+use Nette\Object;
+use Nette\Utils\Strings;
+
+
+
+class Html5Checker extends Object
+{
+
+	public static function createHtml5CheckerChecker()
+	{
+		return function ($checker, $s) {
+			if (!$checker->is('latte')) {
+				return;
+			}
+
+			if (Strings::match($s, '#<br\W*?\/>#')) {
+				$checker->error('contains XHTML');
+			}
+		};
+	}
+}

src/CodeCheckers/LineLengthChecker.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace CodeCheckers;
+
+use Nette\Object;
+use Nette\Utils\Strings;
+
+
+
+class LineLengthChecker extends Object
+{
+
+	public static function createLineLengthChecker($warningLineLength = 140, $errorLineLength = 210)
+	{
+		return function ($checker, $s) use ($warningLineLength, $errorLineLength) {
+			if (!$checker->is('php') && !$checker->is('phpt')) {
+				return;
+			}
+
+			$i = 0;
+			foreach (explode("\n", $s) as $line) {
+				$i++;
+				$line = str_replace("\t", str_repeat(' ', 4), $line);
+				$lineLength = Strings::length($line);
+				$message = sprintf('Line %s have %d characters', Strings::truncate(Strings::trim($line), 30), $lineLength);
+
+				if ($lineLength > $errorLineLength) {
+					$checker->error($message, $i);
+					continue;
+				}
+				if ($warningLineLength !== NULL && $lineLength > $warningLineLength) {
+					$checker->warning($message, $i);
+				}
+			}
+		};
+	}
+}

src/CodeCheckers/NeonChecker.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace CodeCheckers;
+
+use Nette\Object;
+
+
+
+class NeonChecker extends Object
+{
+
+	public static function createBooleanValuesChecker()
+	{
+		return function ($checker, $s) {
+			if (!$checker->is('neon')) {
+				return;
+			}
+
+			$lines = explode("\n", $s);
+			foreach ($lines as &$line) {
+				if (preg_match('~^(.*):( )?(yes|on|no|off)$~i', $line)) {
+					$message = sprintf('Boolean values should be true/false: %s', $line);
+					$checker->fix($message);
+					$line = preg_replace('~:( )?(yes|on)$~i', ': true', $line);
+					$line = preg_replace('~:( )?(no|off)$~i', ': false', $line);
+				}
+			}
+
+			return implode("\n", $lines);
+		};
+	}
+}

src/code-checker.php

@@ -6,10 +6,19 @@
  * This file is part of the Nette Framework (https://nette.org)
  */
 
-use Nette\Utils\Strings;
+use CodeCheckers\EntityChecker;
+use CodeCheckers\LineLengthChecker;
+use CodeCheckers\Html5Checker;
+use CodeCheckers\NeonChecker;
 use Nette\CommandLine\Parser;
+use Nette\Utils\Strings;
+
+$loaders = array_filter([
+	__DIR__ . '/../vendor/autoload.php',
+	__DIR__ . '/../../../autoload.php',
+], 'file_exists');
 
-if (@!include __DIR__ . '/../vendor/autoload.php') {
+if (@!include reset($loaders)) {
 	echo('Install packages using `composer update`');
 	exit(1);
 }
@@ -373,6 +382,27 @@ public function is($extensions)
 	}
 };
 
+// cs, missing @testCase in phpt files
+$checker->tasks[] = function (CodeChecker $checker, $s) {
+	if ($checker->is('phpt')) {
+		if (!Strings::contains($s, ' * @testCase')) {
+			$checker->error('Missing @testCase');
+		}
+	}
+};
+
+// cs, entity
+$checker->tasks[] = EntityChecker::createAnnotationsChecker();
+
+//max line length
+$checker->tasks[] = LineLengthChecker::createLineLengthChecker(NULL, 360);
+
+//html5 <br/>
+$checker->tasks[] = Html5Checker::createHtml5CheckerChecker();
+
+//boolean (yes, on -> true, no, off -> false)
+$checker->tasks[] = NeonChecker::createBooleanValuesChecker();
+
 $ok = $checker->run($options['-d']);
 
 exit($ok ? 0 : 1);

tests/.gitignore

@@ -0,0 +1,3 @@
+/*/output
+/test.log
+/tmp

tests/CodeCheckers/EntityChecker.phpt

@@ -0,0 +1,100 @@
+<?php
+/**
+ * @testCase
+ */
+
+namespace CodeCheckerTests;
+
+use CodeCheckers\EntityChecker;
+use Tester\Assert;
+use Tester\TestCase;
+
+require __DIR__ . '/../bootstrap.php';
+
+
+
+class FakeChecker
+{
+
+	public $fixMessages = [];
+
+
+
+	public function fix($message)
+	{
+		$this->fixMessages[] = $message;
+	}
+
+
+
+	public function is($file)
+	{
+		return TRUE;
+	}
+}
+
+
+
+class EntityCheckerTest extends TestCase
+{
+	/**
+	 * @var FakeChecker
+	 */
+	private $fakeChecker;
+
+
+
+	public function setup()
+	{
+		$this->fakeChecker = new FakeChecker();
+	}
+
+
+
+	/**
+	 * @dataProvider getDataForTestEntity
+	 */
+	public function testEntity($input, $output, $countOfFixMessages)
+	{
+		$annotationChecker = EntityChecker::createAnnotationsChecker();
+		Assert::same($output, $annotationChecker($this->fakeChecker, $input));
+		Assert::count($countOfFixMessages, $this->fakeChecker->fixMessages);
+	}
+
+
+
+	public function getDataForTestEntity()
+	{
+		return [
+			['@ORM\Entity', '@ORM\Entity()', 1],
+			['@ORM\Entity()', '@ORM\Entity()', 0],
+		];
+	}
+
+
+
+	/**
+	 * @dataProvider getDataForTestTableName
+	 */
+	public function testTableName($input, $output, $countOfFixMessages)
+	{
+		$annotationChecker = EntityChecker::createAnnotationsChecker();
+		Assert::same($output, $annotationChecker($this->fakeChecker, $input));
+		Assert::count($countOfFixMessages, $this->fakeChecker->fixMessages);
+	}
+
+
+
+	public function getDataForTestTableName()
+	{
+		return [
+			['@ORM\Table()', '@ORM\Table(name="")', 1],
+			['@ORM\Table', '@ORM\Table(name="")', 1],
+			['@ORM\Table(name="table_name")', '@ORM\Table(name="table_name")', 0],
+		];
+	}
+}
+
+
+
+\run(new EntityCheckerTest());