-
Notifications
You must be signed in to change notification settings - Fork 351
fix: reexport full dns module from iroh-relay #3916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3916/docs/iroh/ Last updated: 2026-02-09T15:02:31Z |
iroh/src/dns.rs
Outdated
| pub use iroh_relay::dns::{ | ||
| DnsResolver, N0_DNS_ENDPOINT_ORIGIN_PROD, N0_DNS_ENDPOINT_ORIGIN_STAGING, | ||
| }; | ||
| pub use iroh_relay::dns::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sceptical of glob exports, how much would it be to make these explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, it's just that we had this in the past and then forgot to update it when we added a new type in iroh_relay::dns that was used in a method of Resolver. So to prevent that I'd prefer a glob export. Or even just reexport the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just reexport the module and move the tests somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe cc @ramfox who thought about exports the most
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit that fully reexports the dns module. I think this is much cleaner.
Description
We currently only export some types from
iroh_relay::dnsasiroh::dns. This means if you actually want to customize the DNS resolver you have to add a dependency oniroh_relayto your crate, because several of the types needed are currently not exported fromiroh.This fixes it by reexporting the whole
iroh_relay::dnsmodule asiroh::dns.Also fixes a few doccomments.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme