fix: configure git identity in cleanup workflow #3920
Conversation
The clean_docs_branch job fails with "fatal: empty ident name" because no git user.name/email is configured. Also handles the case where there are no old docs to clean up.
There was a problem hiding this comment.
Pull request overview
Fixes the scheduled “Cleanup” GitHub Actions workflow so it can successfully commit/push changes on the generated-docs-preview branch, and cleanly no-op when there’s nothing to remove.
Changes:
- Configure
git user.name/git user.emailin the cleanup job before committing. - Exit early with a clear message when the cleanup produces no staged changes (avoids failing
git commit).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3920/docs/iroh/ Last updated: 2026-02-10T10:38:59Z |
| - name: Clean docs branch | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" |
There was a problem hiding this comment.
is this a valid email? does this work?
There was a problem hiding this comment.
Yes https://github.com/orgs/community/discussions/26560 this thing lacks docs but is the standard convention to attribute these types of actions to the github bot. Also I think we already use it somewhere else.
There was a problem hiding this comment.
Also you can see it here in action https://github.com/n0-computer/iroh/commits/generated-docs-preview/
## Summary - The `clean_docs_branch` job fails with `fatal: empty ident name` because no git `user.name`/`user.email` is configured on the runner - Also adds a guard for the "nothing to commit" case (when ≤25 PR dirs exist) Same fix as n0-computer/iroh#3920
## Summary - The `clean_docs_branch` job fails with `fatal: empty ident name` because no git `user.name`/`user.email` is configured on the runner - Also adds a guard for the "nothing to commit" case (when ≤25 PR dirs exist) Same fix as n0-computer/iroh#3920
## Summary - The `clean_docs_branch` job fails with `fatal: empty ident name` because no git `user.name`/`user.email` is configured on the runner - Also adds a guard for the "nothing to commit" case (when ≤25 PR dirs exist) Same fix as n0-computer/iroh#3920
## Summary - The `clean_docs_branch` job fails with `fatal: empty ident name` because no git `user.name`/`user.email` is configured on the runner - Also adds a guard for the "nothing to commit" case (when ≤25 PR dirs exist) Same fix as n0-computer/iroh#3920
## Summary - The `clean_docs_branch` job fails with `fatal: empty ident name` because no git `user.name`/`user.email` is configured on the runner - Also adds a guard for the "nothing to commit" case (when ≤25 PR dirs exist) Same fix as n0-computer/iroh#3920
3 participants
Description
The clean_docs_branch job fails with "fatal: empty ident name" because no git user.name/email is configured. Also handles the case where there are no old docs to clean up.
✅ workflow https://github.com/n0-computer/iroh/actions/runs/21824443730/job/62965614616
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme