Draft
Conversation
Collaborator
|
Not sure if this is the right way to go. It adds quite a bit of complexity. Ideally you would be able to mash together lots of different services on a single endpoint if the enum discriminator was not just a varint but something that actually describes the request semantically. I would rather follow the latter approach, which is what I prototyped in https://crates.io/crates/irpc-schema . |
Member
Author
|
Yeah, let's leave it as a draft for a bit, I also wanna play with irpc-schema more before committing to this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(draft)
Adds
Client::mapandMappedClientto easily perform requests on embedded (nested) services.This allows composing services within a single protocol / connection.
Also adds a
nestedargument to therpcmacro to allow doing this via the macro. Ifnestedis set, noWithChannelsconversions are created, instead the message contains the message specified via thenestedargument.See the nested example.