For #10: Prevent overlap of pause and resume buttons#75
For #10: Prevent overlap of pause and resume buttons#75czlucius wants to merge 1 commit intonaXa777:masterfrom
Conversation
|
@naXa777 can you review this PR and see if it's ok? |
|
@czlucius please resolve the conflict |
There was a problem hiding this comment.
actually your fix works: pause and stop buttons don't overlap anymore. tested in landscape split screen mode on Android 7 / Nexus 5.
BEFORE changes
AFTER changes
But there's a new problem now: circular progress bar is on top. Please fix it, post demo screenshots, and I'll merge the PR.
| android:layout_gravity="center_vertical" | ||
| android:layout_marginHorizontal="16dp" | ||
| app:backgroundTint="@color/primary" | ||
| app:elevation="6dp" |
There was a problem hiding this comment.
for some reason, app:elevation has no effect after this change.
to simulate a small screen, I'm using a split screen in landscape mode for testing. Device: Android 12 / Google Pixel 3. please take a look at the screenshots below.
BEFORE your changes (master branch)
1
2
AFTER your changes
1
2
as you can see, there's a visual regression. RECORD/STOP and PAUSE/RESUME buttons are now overlapping with the circular progress bar. But buttons should be on top.
2 participants
Arranges the buttons in a horizontal LinearLayout to prevent overlap.