-
Notifications
You must be signed in to change notification settings - Fork 0
Implement plugin distribution workflow and PR review improvements #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- 許可・拒否操作の権限設定を追加 - 危険なコマンド(rm -rf、dd、mkfsなど)を拒否 - 環境変数アクセス(env、exportなど)を拒否 - WSLからのWindowsホストアクセスを拒否 - セキュリティのため.envファイルへのアクセスを拒否 - git、ファイル操作、Claude Codeツールを許可 - settings.local.jsonを除外するようgitignoreを更新 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude Code統合を含む開発環境の自動セットアップスクリプトと、 READMEに包括的なセットアップ手順を追加 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- CLAUDE.mdをシンプルなルールのみの記述に変更 - setup.shにNablarch公式リポジトリのクローン機能を追加 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- シェルスクリプトを使用したカスタムステータスラインを設定 - document-skillsプラグインを有効化 - カレントディレクトリ、gitブランチ、モデル、コンテキスト使用率を表示 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
エージェントから実行可能な構造で、ブランチ作成、コミット、ブランチ削除、ワークツリー作成/削除の5つの操作をサポート Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude (jp.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
- ディレクトリ構成を簡潔化(nabledge-6/研究ドキュメントの詳細は削除) - 詳細設計はstep3-architecture-design.mdへのリンクで参照 - 情報の重複を排除 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- /git commitの説明を「コミット」→「コミット&プッシュ」に変更 - 実際の動作と説明を一致させる Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Nablarchエージェント代行のための構造化知識基盤の設計書を追加。 要件定義、アーキテクチャ設計、実現性評価、レビュー結果、実装計画を含む。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
プロジェクトの開発環境を整備し、Nablarch 6用の構造化知識基盤の初期実装を追加。 permission設定、Git/PRスキルのリファクタリング、ワークフロー定義、ルール設定を含む。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- バージョン1.4に更新、変更履歴を追加 - 代行業務の優先度を整理し明確化 - 冗長な説明を削除し、構造を4章に簡潔化 - 文体を統一(「です・ます」調) - スクリプトファイルに実行権限を付与 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
index.toonの検索ヒントを整理し、冗長なキーワードを削減。keyword-searchワークフローにL1/L2/L3キーワードの使い分けを明記し、2段階フィルタリング(ファイル選定・セクション選定)の設計を明確化。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
検索アーキテクチャから検索設計に名称変更し、6段階の詳細フロー(キーワード抽出→ファイル選定→セクション選定→関連度判定→結果構造化→コンテキスト管理)を図解とともに説明。各段階での処理内容と判断根拠を明確化。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
重複していたコンテキスト管理の説明を検索設計の「⑥ コンテキスト管理」に統合。まとめセクションも更新し、検索設計の4つのポイント(3段階キーワード、2段階検索、関連度判定、セクション単位抽出)を明記。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
検索設計の全面見直し(3段階キーワード抽出+2段階検索プロセス)を反映したバージョン履歴を追加。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
テストシナリオをnabledge-6/tests/から独立したスキル構造に移行し、 ワークフロー駆動のテスト実行とレビュー機能を追加 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Create workflow to sync nabledge-6 skill to dummy-to branch - Trigger on push to dummy-from branch - Include trigger commit URL in commit message for traceability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added version 0.2 with README restructuring changes: - Categorized features into knowledge and workflow sections - Enhanced marketplace README with purpose explanation - Simplified plugin table with status column Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GitHub Action:
- Add automatic Git tag creation based on plugin.json version
- Tags are created in v{version} format (e.g., v0.3)
- Skip tag creation if tag already exists on remote
Documentation:
- Add team setup instructions with project-scoped installation
- Add .claude/settings.json configuration examples
- Add version update methods for Claude Code and GitHub Copilot
- Add --scope project option to installation commands
Version: 0.2 -> 0.3
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Marketplace README: - Remove team setup section to keep it simple - Keep only plugin list and links Plugin README: - Focus on team setup (no personal installation) - Simplify to "create settings.json and push to Git" for Claude Code - Simplify to "run setup script and push .claude directory" for GitHub Copilot - Remove unnecessary details about --scope project option Version: 0.3 -> 0.4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed from manual settings.json creation to command-based installation: - Use /plugin install with --scope project - settings.json is automatically updated by commands - Commit the updated settings.json to Git - Version specification also uses commands (marketplace re-add with tag) Version: 0.4 -> 0.5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
User-added marketplaces do NOT auto-update by default (only official Anthropic marketplaces do). Changed version update instructions: - Removed incorrect "auto-update at startup" statement - Added manual update command: /plugin marketplace update nabledge - Kept specific version specification with tag Version: 0.5 -> 0.6 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Simplified version update instructions to only support latest version: - Removed tag-based version specification for Claude Code - Removed version-specific URL for GitHub Copilot - Focus on straightforward "update to latest" workflow Version: 0.6 -> 0.7 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Simplified CHANGELOG to only include user-facing features: - Removed development versions 0.2-0.7 - Kept only version 0.1 with end-user relevant features - Reset version numbers to 0.1 in plugin.json and marketplace.json Version: 0.7 -> 0.1 (initial release) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed transform script to copy LICENSE from .claude/marketplace/ instead of repository root for consistency: - README.md comes from .claude/marketplace/ - LICENSE should also come from .claude/marketplace/ - Root LICENSE is for nabledge-dev repository itself Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removed duplicate fields that are already defined in plugin.json: - version - description - homepage - repository - license According to Claude Code spec, plugin.json takes priority. Keep only required fields (name, source) in marketplace.json to avoid double maintenance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed tag naming from v0.1 to 0.1 format. Tags now match the version number exactly without prefix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed release link from v0.1 to 0.1 to match the new tag format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added scripts directory to transform-to-plugin.sh so that setup.sh for GitHub Copilot installation is included in the distribution repository. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed setup.sh to: - Download from plugins/nabledge-6 instead of .claude - Create .claude/skills/nabledge-6/ structure in target project - Work outside of git repositories - Save PROJECT_ROOT path correctly Version: 0.1 -> 0.2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed URLs from development repository structure to distribution structure: - .claude/skills/nabledge-6/scripts/setup.sh → plugins/nabledge-6/scripts/setup.sh Version: 0.2 -> 0.3 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed setup.sh to properly transform distribution structure to user project structure:
Distribution (marketplace):
plugins/nabledge-6/
skills/nabledge-6/SKILL.md
workflows/ assets/ knowledge/ docs/ scripts/
User project (after setup):
.claude/skills/nabledge-6/
SKILL.md
workflows/ assets/ knowledge/ docs/ scripts/
- Copy skills/nabledge-6/* content to .claude/skills/nabledge-6/ root
- Copy supporting directories from plugin root
- Skip .claude-plugin/ (not needed in user project)
Version: 0.3 -> 0.4
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed setup.sh to explicitly clone from dummy-to branch for testing. This will be changed to main branch before final release. Version: 0.4 -> 0.5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed structure so distribution and usage are identical:
Distribution (marketplace):
plugins/nabledge-6/skills/nabledge-6/
SKILL.md workflows/ assets/ knowledge/ docs/ scripts/
Usage (after setup):
.claude/skills/nabledge-6/
SKILL.md workflows/ assets/ knowledge/ docs/ scripts/
Changes:
- transform-to-plugin.sh: Copy supporting dirs into skills/nabledge-6/
- setup.sh: Simplified to copy skills/nabledge-6/ as-is
Version: 0.5 -> 0.6
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Updated GitHub Action validation to check for supporting directories inside skills/nabledge-6/ instead of at plugin root. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Changed URL path to reflect scripts directory inside skills/nabledge-6/: - plugins/nabledge-6/scripts/setup.sh → plugins/nabledge-6/skills/nabledge-6/scripts/setup.sh Version: 0.6 -> 0.7 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename setup.sh to setup-ghc.sh (GitHub Copilot) - Add setup-cc.sh for Claude Code (auto-edits settings.json) - setup-cc.sh safely merges with existing settings - Update README with separate installation instructions - Add workflow validation for both setup scripts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move setup scripts from .claude/skills/nabledge-6/scripts/ to /scripts/ - Rename to setup-6-cc.sh and setup-6-ghc.sh for clarity - Copy to distribution repository root for shorter URLs - Update README with simplified installation paths - Update workflow validation for new script locations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Reset CHANGELOG.md to version 0.1 (remove dev versions 0.2-0.9) - Reset plugin.json to version 0.1 - Update workflow to trigger on main branch - Update workflow to sync to nablarch/nabledge main branch - Update setup scripts to use main branch instead of dummy-to Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Setup scripts now automatically install jq if not present - Linux/WSL: Uses apt-get with sudo - GitBash: Downloads jq.exe from GitHub releases - macOS: Prompts user to install manually via brew - Update README to reflect automatic installation - Remove manual installation instructions from README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Revert version back to 0.1 (was incorrectly bumped to 0.2) - Merge jq auto-install feature into 0.1 release - This is still the initial release Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Initial release should only list features - Setup scripts are expected to exist, no need to document Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Tests are managed separately - Already handled elsewhere Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add metadata.version to marketplace.json (centralized version) - Move description to metadata.description (proper schema) - Update GitHub Action to read version from marketplace.json - Individual plugins keep their own versions in plugin.json - Marketplace version represents overall release (nabledge-6 + nabledge-5) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the complete plugin distribution workflow and PR review comment improvements.
Changes
1. Plugin Distribution Workflow
.claude/skills/nabledge-6/plugin/directory structureplugin.json(v0.1.0)README.md(installation and usage)LICENSE(Apache 2.0)CHANGELOG.md.github/scripts/transform-to-plugin.shtransformation script.github/workflows/sync-to-nabledge.ymlGitHub Action2. PR Review Workflow Improvements
.claude/skills/pr/workflows/resolve.mdin_reply_toparameter3. Documentation
work/20260212/github-action-plugin-distribution.mddesign document4. Cleanup
Testing
Before Merge Checklist
IMPORTANT: Complete these tasks before merging to main:
dummy-from→mainin nabledge-dev repositorydummy-to→mainin nabledge repositoryBRANCH="dummy-to"→BRANCH="main"References
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com