ASoC: qcom: q6dsp: Add Senary MI2S interface support#11
Open
mohsRafi wants to merge 2 commits intonandamajay:masterfrom
Open
ASoC: qcom: q6dsp: Add Senary MI2S interface support#11mohsRafi wants to merge 2 commits intonandamajay:masterfrom
mohsRafi wants to merge 2 commits intonandamajay:masterfrom
Conversation
Qualcomm platforms support the Senary MI2S interface for audio playback and capture. Add a new definitions for the Senary MI2S RX and TX ports, which are required for boards that utilize the Senary MI2S interface for audio routing. Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Introduces support for the Senary MI2S audio interface in the Qualcomm q6dsp. Add new AFE port IDs for Senary MI2S RX and TX and include the necessary mappings in the port configuration to allow audio routing over the Senary MI2S interface. Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Srinivas-Kandagatla
left a comment
Srinivas-Kandagatla
left a comment
There was a problem hiding this comment.
Other than those two comments, it looks good to me, Please send it in mailing list once those are addressed.
| #define DISPLAY_PORT_RX_7 135 | ||
| #define USB_RX 136 | ||
| #define SENARY_MI2S_RX 137 | ||
| #define SENARY_MI2S_TX 138 |
There was a problem hiding this comment.
Pl update ./sound/soc/qcom/lpass.h #define LPASS_MAX_PORTS
| SND_SOC_DAPM_AIF_OUT("SLIMBUS_5_TX", NULL, 0, SND_SOC_NOPM, 0, 0), | ||
| SND_SOC_DAPM_AIF_OUT("SLIMBUS_6_TX", NULL, 0, SND_SOC_NOPM, 0, 0), | ||
| SND_SOC_DAPM_AIF_IN("SEN_MI2S_RX", NULL, | ||
| 0, SND_SOC_NOPM, 0, 0), |
Author
There was a problem hiding this comment.
sure will address comments and sent over mailing list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Senary MI2S interface support for Qualcomm boards.
Mohammad Rafi Shaik (2):
ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add Senary MI2S port
ASoC: qcom: q6dsp: Add Senary MI2S audio interface support
.../sound/qcom,q6dsp-lpass-ports.h | 2 ++
sound/soc/qcom/qdsp6/q6afe-dai.c | 8 +++++
sound/soc/qcom/qdsp6/q6afe.c | 6 ++++
sound/soc/qcom/qdsp6/q6afe.h | 2 +-
sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 29 +++++++++++++++++++
5 files changed, 46 insertions(+), 1 deletion(-)