This repository was archived by the owner on Sep 11, 2019. It is now read-only.
Эксперимент с Menu <Menu2 renderItem={<MenuItem2/>}>#3
Open
doochik wants to merge 3 commits intonarqo:masterfrom
Open
Эксперимент с Menu <Menu2 renderItem={<MenuItem2/>}>#3doochik wants to merge 3 commits intonarqo:masterfrom
doochik wants to merge 3 commits intonarqo:masterfrom
Conversation
| * | ||
| * <Menu2 | ||
| * theme="islands" | ||
| * renderItem={<MenuItem2/>} |
Owner
There was a problem hiding this comment.
По-моему — адЪ. Я бы совсем не хотел, на проекте так описывать компоненты.
Collaborator
Author
There was a problem hiding this comment.
У этого подхода есть несколько плюсов (хотя минусов тоже хватает :) ).
Почти любой нестандартный MenuItem разработчик рано или поздно завернет в компонент, а значит он из раза в раз будет писать одну и ту же балалайку в своем коде
<Menu>
{data.map((item) => <MyMenuItem/>)}
</Menu>
Плюс такой подход скрывает реализацию Menu и еще приближает к более удобной схеме генерации: массив + render fn = список
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Запилил ради интереса, чтобы можно было передавать каким компонентом рендерить элемент меню.